Address @adobe/data-ai review-bot findings (rule scope, layering, supply-chain) - #162
Merged
Conversation
- global/ folder for the intentionally repo-wide rules (namespace, cohesion, type-casts, function-references, react) — breadth is now explicit, not accidental; cross-refs + README updated. - build-transactions extends the actual preceding layer (IndexDatabase or CoreDatabase); build-systems combines the scheduler with the current top layer (Action/Service/ComputedDatabase), not a hardcoded ComputedDatabase. - installer excludes maintainer-only skills (meta-build, review) from consumer installs and emits a version-pinned bootstrap rule (never @latest); meta-build/review get disable-model-invocation. - inclusive terminology in binding-element.md; README layer shape corrected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #161, addressing the Talos review-bot findings raised where this bundle was installed into Firefly Platform (Adobe-Firefly/firefly-platform#13601).
Changes
namespace,cohesion,type-casts,function-references,react) intorules/global/. The broad**/*.ts(x)globs are kept by design (these are meant to apply everywhere); the folder name signposts that intent rather than leaving it looking accidental. Cross-refs + READMEs updated.build-transactionsnow extends the actual preceding layer (IndexDatabaseif indexes were built, elseCoreDatabase);build-systemscombines the scheduler with the feature's current top layer (Action/Service/ComputedDatabase), not a hardcodedComputedDatabase, so systems + services/actions compose into oneFeatureDatabase.meta-build,review) from consumer installs; emits a version-pinnedadobe-data-ai-bootstrap.md(npx @adobe/data-ai@<version> install, never@latest), regenerated each install;disable-model-invocation: trueon the two eval skills.binding-element.md"whitelist" → "allowlist"; corrected the package README's staledata → ecs → uitodata → services → ui.Not here (FFP-side)
The lockstep
@adobe/databump in FFP and the rule-load probe manifests stay on the FFP PR; the FFP bootstrap file was already pinned there — this change makes that pin self-maintaining for all consumers.🤖 Generated with Claude Code